[FFmpeg-devel] [PATCH] lavf/matroskaenc: improve tag-skipping checks

Michael Niedermayer michael at niedermayer.cc
Wed Aug 31 11:52:55 EEST 2016


On Wed, Aug 31, 2016 at 01:05:31AM -0500, Rodger Combs wrote:

> - Add "duration" to list of skipped attributes (we handle that elsewhere)

> - Move the list to its own function and make its use consistent

These 2 should be in separate patches
code moving and code changes are more readable when in seperate diffs

Also this changes a fate test checksum:
--- -   2016-08-31 10:28:19.016237007 +0200
+++ tests/data/fate/matroska-remux      2016-08-31 10:28:19.007989456 +0200
@@ -1 +1 @@
-5ebcfaa8e3d534f8a800a58fd2b0aca6
+f08b20b90f158a4de5a02a52c25596b9
Test matroska-remux failed. Look at tests/data/fate/matroska-remux.err for details.
make: *** [fate-matroska-remux] Error 1



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160831/bace04e0/attachment.sig>


More information about the ffmpeg-devel mailing list