[FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

[Michael Niedermayer]

On Sat, Dec 03, 2016 at 01:14:19AM +0100, Andreas Cadhalpun wrote:
> On 03.12.2016 00:52, Michael Niedermayer wrote:
> > Modern ffserver should not need these
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/ffmdec.c | 148 +++++++++++++++++++++++++--------------------------
> >  1 file changed, 74 insertions(+), 74 deletions(-)
> > 
> > diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c
> > index 960e793220..9192bff507 100644
> > --- a/libavformat/ffmdec.c
> > +++ b/libavformat/ffmdec.c
> > @@ -405,51 +405,51 @@ static int ffm2_read_header(AVFormatContext *s)
> >              ret = av_image_check_size(codec->width, codec->height, 0, s);
> >              if (ret < 0)
> >                  goto fail;
> > -            codec->gop_size = avio_rb16(pb);
> > +            avio_rb16(pb);
> 
> Please add a comment like /* gop_size */ here and similar ones below.
> Otherwise it'll be rather mysterious what's the point of all these avio_rb* calls.

done locally


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161203/44414490/attachment.sig>