[FFmpeg-devel] [PATCH] lavfi/formats: allow unknown channel layouts by default

[Marton Balint]

On Sat, 3 Dec 2016, Marton Balint wrote:

> Since the default in the libav fork is to only allow known layouts, making
> unknown layouts allowed by default here can be a security risk for filters
> directly merged from libav. However, usually it is simple to detect such cases,
> use of av_get_channel_layout_nb_channels is a good indicator, so I suggest we
> change this regardless.
>
> See http://ffmpeg.org/pipermail/ffmpeg-devel/2016-November/203204.html.
>
> This patch indirectly adds unknown channel layout support for filters where
> query_formats is not specified:
>
> abench
> afifo
> ainterleave
> anullsink
> apad
> aperms
> arealtime
> aselect
> asendcmd
> asetnsamples
> asetpts
> asettb
> ashowinfo
> asyncts
> azmq
>
> And it removes .query_format callback from filters where it was only there to
> support unknown layouts, as this is now the default:
>
> aloop
> ametadata
> anull
> asidedata
> asplit
> atrim
>
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
> libavfilter/af_anull.c   |  1 -
> libavfilter/f_loop.c     |  1 -
> libavfilter/f_metadata.c |  1 -
> libavfilter/f_sidedata.c |  1 -
> libavfilter/formats.c    |  5 -----
> libavfilter/formats.h    | 10 ----------
> libavfilter/split.c      |  1 -
> libavfilter/trim.c       |  1 -
> 8 files changed, 21 deletions(-)
>

I will apply this in a few days, unless someone objects.

Thanks,
Marton