[FFmpeg-devel] [PATCH] avformat/wavdec: Eliminate goto for clang -O0 DCE

Michael Niedermayer michael at niedermayer.cc
Fri Dec 16 14:22:38 EET 2016


On Thu, Dec 15, 2016 at 04:44:57PM -0800, Mark Harris wrote:
> Clang is not able to eliminate the reference to ff_spdif_probe() when
> there is a goto target in the same block and optimization is disabled.
> 
> This fixes the following build failure on OS X:
>   ./configure --disable-everything --disable-doc \
>     --enable-decoder=pcm_s16le --enable-demuxer=wav \
>     --enable-protocol=file --disable-optimizations --cc=clang
>   make
>   ...
>   Undefined symbols for architecture x86_64:
>     "_ff_spdif_probe", referenced from:
>         _set_spdif in libavformat.a(wavdec.o)
>   ld: symbol(s) not found for architecture x86_64
> ---
>  libavformat/wavdec.c | 38 +++++++++++++++++---------------------
>  1 file changed, 17 insertions(+), 21 deletions(-)

applied, this code is simpler than before too

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161216/4bae8733/attachment.sig>


More information about the ffmpeg-devel mailing list