[FFmpeg-devel] [PATCH] avfilter/af_apulsator: assert that pathes leaving uninitialized variables do not occur

[Michael Niedermayer]

On Thu, Feb 04, 2016 at 10:14:53AM +0100, Paul B Mahol wrote:
> On 2/4/16, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > Fixes: CID1341581, CID1341582
> >
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavfilter/af_apulsator.c |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/libavfilter/af_apulsator.c b/libavfilter/af_apulsator.c
> > index 6c81530..802b8d0 100644
> > --- a/libavfilter/af_apulsator.c
> > +++ b/libavfilter/af_apulsator.c
> > @@ -18,6 +18,7 @@
> >   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
> > USA
> >   */
> >
> > +#include "libavutil/avassert.h"
> >  #include "libavutil/opt.h"
> >  #include "avfilter.h"
> >  #include "internal.h"
> > @@ -117,6 +118,7 @@ static double lfo_get_value(SimpleLFO *lfo)
> >      case SAWDOWN:
> >          val = 1 - phs * 2;
> >          break;
> > +    default: av_assert0(0);
> >      }
> >
> >      return val * lfo->amount;
> > @@ -207,6 +209,7 @@ static int config_input(AVFilterLink *inlink)
> >      case UNIT_BPM:  freq = s->bpm / 60;         break;
> >      case UNIT_MS:   freq = 1 / (s->ms / 1000.); break;
> >      case UNIT_HZ:   freq = s->hz;               break;
> > +    default: av_assert0(0);
> >      }
> >
> >      s->lfoL.freq   = freq;
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> 
> ok

applied

thx

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160204/4c27ecb8/attachment.sig>