[FFmpeg-devel] [PATCH] avfilter: add loop filters

Michael Niedermayer michael at niedermayer.cc
Fri Feb 12 15:49:39 CET 2016


On Fri, Feb 12, 2016 at 03:29:53PM +0100, Nicolas George wrote:
> Le quartidi 24 pluviôse, an CCXXIV, Michael Niedermayer a écrit :
> > This shoudl use av_frame_get_pkt_duration()
> > 
> >     /**
> >      * duration of the corresponding packet, expressed in
> >      * AVStream->time_base units, 0 if unknown.
> >      * Code outside libavutil should access this field using:
> >      * av_frame_get_pkt_duration(frame)
> 
> This was necessary to ensure ABI compatibility both backwards and with the
> fork. Since we do not support the latter, we could allow direct access.

The current API docs require its use, they can be changed, iam not
against that but we should not write code ignoring the docs.
Docs and code must stay in sync, otherwise someone (in this case)
might say "hey all these fields arent allowed to be directly accessed,
so i can reorder them safely ..."


[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160212/e60877d1/attachment.sig>


More information about the ffmpeg-devel mailing list