[FFmpeg-devel] [PATCH] Do not remove HWACCEL flag with FF_API_XVMC

[Ivan Kalvachev]

On 2/15/16, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Mon, Feb 15, 2016 at 8:26 AM, Ivan Kalvachev <ikalvachev at gmail.com>
> wrote:
>
>> On 2/15/16, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
>> > On Mon, Feb 15, 2016 at 2:13 PM, Ivan Kalvachev <ikalvachev at gmail.com>
>> > wrote:
>> >> Do not remove HWACCEL flag with FF_API_XVMC since the
>> >> flag is supposed to be used as generic one.
>> >>
>> >
>> > The flag is unused except by the XVMC decoder, so removing it with it
>> > seems appropriate.
>>
>> Should I add it to the other hwaccel decoders?
>
>
> Would it have a real-world purpose?

Does any of the other Capability flags serve any real-world purpose?
e.g. CAP_DRAW_HORIZ_BAND or  CAP_DR1.

The *_BAND indicates usage of draw_horiz_band callback().
The * _DR1 indicates usage of get_buffer(),
The *_HWACCEL is supposed to indicate usage of get_format() and
availability of certain data, when it is called.

Since the trend is removing codecs that do only hwaccel,
I think it is useful for the application to know that the codec
can do more than software decoding.

Now I see I've missed that there have been a rename and
I actually have to move the name to AV_CODEC_CAP scheme.

I'd like to hear if you still have objections,
before doing v2 of this patch.

Best Regards