[FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

Ricardo Constantino wiiaboo at gmail.com
Mon Jan 4 03:39:41 CET 2016


On 3 January 2016 at 23:13, Jan Ekstrom <jeebjp at gmail.com> wrote:

> Hi,
>
> In general looks good, although it might look a bit weird for someone
> as usually libraries have initialization functions called like that.
> That said, this is what
>
> https://gnupg.org/documentation/manuals/gcrypt/Initializing-the-library.html
> recommends.
>
> My only comment would be that we might want to set the parameter to
> GCRYPT_VERSION instead of NULL, as we most probably care if the
> library loaded matches our version (unless these versions change even
> if API doesn't change).
>

This is where it shows my ignorance but I don't know which of these is the
best way of dealing with that.
I tested all three and they all work with the linked sample.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rtmpdh-Initialize-gcrypt-before-using-it-v1.patch
Type: application/octet-stream
Size: 1287 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160104/c9cfa739/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rtmpdh-Initialize-gcrypt-before-using-it-v2.patch
Type: application/octet-stream
Size: 1412 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160104/c9cfa739/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rtmpdh-Initialize-gcrypt-before-using-it-v3.patch
Type: application/octet-stream
Size: 1481 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160104/c9cfa739/attachment-0002.obj>


More information about the ffmpeg-devel mailing list