[FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets
anshul.ffmpeg at gmail.com
Fri Jan 8 12:54:15 CET 2016
On 6 January 2016 1:55:27 am IST, "Clément Bœsch" <u at pkh.me> wrote:
>On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote:
>> This indeed LGTM, but I'm not the maintainer.
>OK I finally understood why it's done that way: validate_cc_data_pair()
>alters the pkt data, but the decoder isn't supposed to do that.
>So this patch is actually incorrect in this state.
I did not knew, what could be the disadvantage of changing pkt data, I changed it to save some CPU cycles.
But I can change it, if there is any disadvantage.
Over there I have just removed parity bit
Sent from my Android device with K-9 Mail. Please excuse my brevity.
More information about the ffmpeg-devel