[FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

[Michael Niedermayer]

On Sun, Jan 10, 2016 at 07:34:27PM +0000, Ricardo Constantino wrote:
> Tried with 1.5.4 with the link on the first email and another one from
> Crunchyroll and it worked.
> Tried compiling 1.5.0 but didn't work (on MinGW).

>  rtmpdh.c |   11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 7a699f49fd1b4a33f4533702578d8ddd5b6ff7ad  0001-rtmpdh-Initialize-gcrypt-before-using-it.patch
> From 821a9f99d04270a9c76c2c9ca897b1ace4227237 Mon Sep 17 00:00:00 2001
> From: Ricardo Constantino <wiiaboo at gmail.com>
> Date: Tue, 29 Dec 2015 21:40:14 +0000
> Subject: [PATCH] rtmpdh: Initialize gcrypt before using it
> 
> Signed-off-by: Ricardo Constantino <wiiaboo at gmail.com>
> ---
>  libavformat/rtmpdh.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/rtmpdh.c b/libavformat/rtmpdh.c
> index 91b1349..42ad72c 100644
> --- a/libavformat/rtmpdh.c
> +++ b/libavformat/rtmpdh.c
> @@ -97,7 +97,16 @@
>          mpz_fdiv_r_2exp(bn, bn, num_bits);            \
>      } while (0)
>  #elif CONFIG_GCRYPT
> -#define bn_new(bn)                  bn = gcry_mpi_new(1)
> +#define bn_new(bn)                                              \
> +    do {                                                        \
> +        if (!gcry_control(GCRYCTL_INITIALIZATION_FINISHED_P)) { \
> +            if (!gcry_check_version("1.5.4"))                   \
> +                return AVERROR(EINVAL);                         \

> +            gcry_control(GCRYCTL_DISABLE_SECMEM, 0);            \

please explain in the commit message why secmem is disabled

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160110/cae2ca1d/attachment.sig>