[FFmpeg-devel] [PATCH] videodsp: fix 1-byte overread in top/bottom READ_NUM_BYTES iterations.
Ronald S. Bultje
rsbultje at gmail.com
Mon Jan 18 17:29:50 CET 2016
On Mon, Jan 18, 2016 at 10:44 AM, Michael Niedermayer <
michael at niedermayer.cc> wrote:
> On Sat, Jan 16, 2016 at 02:44:47PM -0500, Ronald S. Bultje wrote:
> > This can overread (either before start or beyond end) of the buffer in
> > Nx1 (i.e. height=1) images.
> > Fixes mozilla bug 1240080.
> > ---
> > libavcodec/x86/videodsp.asm | 21 ++++++---------------
> > 1 file changed, 6 insertions(+), 15 deletions(-)
> probably ok but iam not confident that i would spot a bug in this
> code if there was one
The second patch (videodsp checkasm) is meant to assist in bug-finding by
doing full-coverage runs - i.e. height=1 and alternate edge conditions
(which fate-$codec doesn't really test) - under asan or valgrind.
More information about the ffmpeg-devel