[FFmpeg-devel] [PATCH] libavcodec/util: Fix timebase overflow check

Derek Buitenhuis derek.buitenhuis at gmail.com
Wed Jan 27 22:13:19 CET 2016


It could accidentally divide by zero if num was zero.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
---
 libavcodec/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 13ee243..491d8ea 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1475,7 +1475,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
         if (!avctx->rc_initial_buffer_occupancy)
             avctx->rc_initial_buffer_occupancy = avctx->rc_buffer_size * 3 / 4;
 
-        if (avctx->ticks_per_frame &&
+        if (avctx->ticks_per_frame && avctx->time_base.num &&
             avctx->ticks_per_frame > INT_MAX / avctx->time_base.num) {
             av_log(avctx, AV_LOG_ERROR,
                    "ticks_per_frame %d too large for the timebase %d/%d.",
-- 
2.7.0



More information about the ffmpeg-devel mailing list