[FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

Mats Peterson matsp888 at yahoo.com
Sun Jan 31 15:21:03 CET 2016


On 01/31/2016 03:20 PM, Michael Niedermayer wrote:
> On Sun, Jan 31, 2016 at 01:33:02PM +0100, wm4 wrote:
>> On Sun, 31 Jan 2016 13:27:22 +0100
>> Mats Peterson <matsp888-at-yahoo.com at ffmpeg.org> wrote:
>>
>>> I don't really appreciate that you're doing things behind my back,
>>> Michael. There's nothing mentioned on the ffmpeg-devel mailing list
>>> about your "monowhite switching patch". Furthermore, to me it's highly
>>> unncecessary to use monowhite whatsoever. The space savings are quite
>>> irrelevant nowadays, and the logic to detect whether a file is black &
>>> white only creates more noise in the code. Here's a patch that restores
>>> the old behaviour of only using pal8 for 1 bpp video, and removes
>>> superfluous monowhite stuff.
>>
>> Less complexity for such a corner case sounds indeed better.
>
> i dont mind reverting my patch if people prefer
>

No need to, just apply my latest patch, which restores the FATE test 
files as well, and includes the removal of superfluous monow stuff.

Mats



More information about the ffmpeg-devel mailing list