[FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report
Carl Eugen Hoyos
cehoyos at ag.or.at
Sun Jul 3 11:35:32 EEST 2016
Burt P. <pburt0 <at> gmail.com> writes:
> + /* For user information/stats, pulled up into HDCDContext
> + * by filter_frame() */
> + int _hdcd_detected;
No leading underscores please, same below.
[...]
> +/* update the user info/flags */
> +#define UPDATE_INFO(s,pe,tg,tf)
I believe this should be a function.
> do{if (pe || tg || tf || s->sustain)
> { s->_hdcd_detected = 1; }
> if (pe) { s->_peak_extend = 1; }
This could be s->peak_extend = !!pe;
[...]
> + int transient_filter = (state->control & 32);
Unneeded parenthesis, feel free to ignore.
[...]
> + s->hdcd_detected = 0;
> + s->peak_extend = 0;
> + s->transient_filter = 0;
These are unneeded, please remove them.
Thank you for the patch, Carl Eugen
More information about the ffmpeg-devel
mailing list