[FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

James Almer jamrial at gmail.com
Wed Jul 13 01:56:47 EEST 2016


On 7/12/2016 7:52 PM, Moritz Barsnick wrote:
> On Tue, Jul 12, 2016 at 18:36:20 -0300, James Almer wrote:
>> +    uint32_t invcnt = !((granule >> 30) & 3);
> 
> If it's just for storing a 0/1 (bool, basically), wouldn't you use the
> more unspecific type "int"? (Not sure whether it matters at all.)
> 
> Moritz

Yeah, int should suffice. I used uint32_t for alignment purposes
with the other variables, but then i added the comment and that
became superfluous i guess.

Changed locally.



More information about the ffmpeg-devel mailing list