[FFmpeg-devel] Fwd: [PATCH] Automatically inserted bitstream filter 'h264_mp4toannexb' into hlsenc

[Michael Niedermayer]

On Wed, Jun 29, 2016 at 01:07:13AM +0200, Hendrik Leppkes wrote:
> On Wed, Jun 29, 2016 at 12:30 AM, Steven Liu <lingjiujianke at gmail.com> wrote:
> >
> >
> > 2016-06-29 0:16 GMT+08:00 Hendrik Leppkes <h.leppkes at gmail.com>:
> >>
> >> On Tue, Jun 28, 2016 at 3:29 PM, Steven Liu <lingjiujianke at gmail.com>
> >> wrote:
> >> > before patched:
> >> > [root at localhost ffmpeg]# ./ffmpeg_g -re -i /root/facebook.mp4 -c copy -f
> >> > hls -v verbose -y aaaa.m3u8
> >> > ffmpeg version N-80779-gb18d6c5 Copyright (c) 2000-2016 the FFmpeg
> >> > developers
> >>
> >>
> >> The way I see it, the auto bsf from the mpegts muxer should already
> >> cover this without changes?
> >
> >
> > add the hls_check_bitstream into hls format and call the hls->avf to call
> > the mpegtsenc's check_bitstream,
> > don't do this operation,  it won't call the mpegtsenc's check_bitstream,
> > look at the message bellow:
> >
> 
> This is the wrong approach to fixing this however, it should be
> understood first why its not doing this transparently right now.
> hlsenc uses the mpegts muxer like one would use any other muxer, so
> why does autobsf not get used?
> 
> If we understand that, maybe it can be fixed in a more generic way,
> and not end up in ugly hacks in hlsenc.

The issue is that hlsenc does call ff_write_chained() which causes
av_write_frame() instead of av_interleaved_write_frame() to be used,
bypassing the current auto bsf code

Using av_interleaved_write_frame() would, i assume introduce a delay

The patch doesnt work either, for example this:
./ffmpeg -i matrixbench_mpeg2.mpg -i fate-suite/sub/MovText_capability_tester.mp4  -f hls     file.m3u8

segfaults

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160713/06f3a0f0/attachment.sig>