[FFmpeg-devel] [PATCH] libavformat/matroskadec: fix unsigned overflow to improve seeking

Michael Niedermayer michael at niedermayer.cc
Sat Jul 23 12:26:35 EEST 2016

On Thu, Jul 21, 2016 at 12:01:45PM -0700, Chris Cunningham wrote:
> When seeking a file where codec delay is greater than 0, the timecode
> can become negative after offsetting by the codec delay. Failing to cast
> to a signed int64 will cause the check against skip_to_timecode to evaluate
> true for these negative values. This breaks the "skip_to" seek mechanism.
> ---
>  libavformat/matroskadec.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)


can you create a fate testcase for this ?
(maybe libavformat/tests/seek.c could be used)

i can upload the sample file to the fate-samples


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160723/a6710f4d/attachment.sig>

More information about the ffmpeg-devel mailing list