[FFmpeg-devel] [PATCH] lavc: always build dnxhddata

James Almer jamrial at gmail.com
Mon Jul 25 18:32:43 EEST 2016


On 7/25/2016 4:36 AM, Michael Niedermayer wrote:
> On Sun, Jul 24, 2016 at 11:43:41PM -0300, James Almer wrote:
>> On 7/24/2016 8:13 PM, Michael Niedermayer wrote:
> [...]
>>>
>>>>
>>>> Looking at this function closely now, it could have been added
>>>> to dnxhddata.h instead. No need for avpriv_ prefix and to
>>>> forcefully build an object file full of data tables that it
>>>> doesn't need.
>>>
>>> agree, this would be best in this case
>>
>> Are you ok with me reverting this commit and moving the function
>> to the header? The symbol will of course not be removed until next
>> major bump since it's already in a release.
>> Alternatively apply "[PATCH] lavf/movenc: add missing dependency
>> on dnxhddata" but IMO it's better to just move the thing to the
>> header.
> 
> yes, moving to the header is better
> 
> thx

Moved then.



More information about the ffmpeg-devel mailing list