[FFmpeg-devel] [PATCH] lavc/vaapi_encoder_{h264, h265}: fix bad format warning

Mark Thompson sw at jkqxz.net
Thu Jun 2 20:09:16 CEST 2016


On 02/06/16 17:20, Matthieu Bouron wrote:
> From: Matthieu Bouron <matthieu.bouron at stupeflix.com>
> 
> ---
>  libavcodec/vaapi_encode_h264.c | 2 +-
>  libavcodec/vaapi_encode_h265.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c
> index 0a99bb1..dc7774b 100644
> --- a/libavcodec/vaapi_encode_h264.c
> +++ b/libavcodec/vaapi_encode_h264.c
> @@ -769,7 +769,7 @@ static av_cold int vaapi_encode_h264_init_constant_bitrate(AVCodecContext *avctx
>      priv->fixed_qp_p   = 26;
>      priv->fixed_qp_b   = 26;
>  
> -    av_log(avctx, AV_LOG_DEBUG, "Using constant-bitrate = %d bps.\n",
> +    av_log(avctx, AV_LOG_DEBUG, "Using constant-bitrate = %"PRId64" bps.\n",
>             avctx->bit_rate);
>      return 0;
>  }
> diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c
> index 05d3aa4..17cd900 100644
> --- a/libavcodec/vaapi_encode_h265.c
> +++ b/libavcodec/vaapi_encode_h265.c
> @@ -1196,7 +1196,7 @@ static av_cold int vaapi_encode_h265_init_constant_bitrate(AVCodecContext *avctx
>      priv->fixed_qp_p   = 30;
>      priv->fixed_qp_b   = 30;
>  
> -    av_log(avctx, AV_LOG_DEBUG, "Using constant-bitrate = %d bps.\n",
> +    av_log(avctx, AV_LOG_DEBUG, "Using constant-bitrate = %"PRId64" bps.\n",
>             avctx->bit_rate);
>      return 0;
>  }
> 

LGTM to fix the warning.

I didn't realise that bit_rate has a different type in the two tines - I think a bit more is needed here to just reject higher numbers because all of the relevant fields in va.h structures are 32-bit anyway...



More information about the ffmpeg-devel mailing list