[FFmpeg-devel] [PATCH] lavf/udp: fix dead code.

Nicolas George george at nsup.org
Fri Jun 3 11:21:23 CEST 2016


Since d607861, service can not be NULL, only "0".
An UDP address with neither local port nor address leaves both
service and node to their default value, and POSIX specifies
that they are not allowed to be both NULL; "0" is equivalent
to an unspecified port for all currently known protocols.

Fix CID 1341570.

Signed-off-by: Nicolas George <george at nsup.org>
---
 libavformat/udp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/udp.c b/libavformat/udp.c
index 0f35689..531e254 100644
--- a/libavformat/udp.c
+++ b/libavformat/udp.c
@@ -264,7 +264,7 @@ static struct addrinfo *udp_resolve_host(URLContext *h,
         res = NULL;
         av_log(h, AV_LOG_ERROR, "getaddrinfo(%s, %s): %s\n",
                node ? node : "unknown",
-               service ? service : "unknown",
+               service,
                gai_strerror(error));
     }
 
-- 
2.8.1



More information about the ffmpeg-devel mailing list