[FFmpeg-devel] [PATCH 2/2] avformat/rawdec: Fix avg_framerate for h264

Michael Niedermayer michael at niedermayer.cc
Tue Jun 7 14:02:54 CEST 2016


On Sat, Jun 04, 2016 at 02:36:53AM +0200, Michael Niedermayer wrote:
> On Fri, Jun 03, 2016 at 07:39:08PM -0400, Ronald S. Bultje wrote:
> > Hi,
> > 
> > On Fri, Jun 3, 2016 at 6:12 PM, Michael Niedermayer <michael at niedermayer.cc>
> > wrote:
> > 
> > > The framerate is 25 which is a fixed default and is wrong undo the 1 line
> > > change which caused this regression
> > > Fixes Ticket 5444
> > >
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > > ---
> > >  libavformat/rawdec.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/libavformat/rawdec.c b/libavformat/rawdec.c
> > > index 8c734db..2bcb672 100644
> > > --- a/libavformat/rawdec.c
> > > +++ b/libavformat/rawdec.c
> > > @@ -84,8 +84,8 @@ int ff_raw_video_read_header(AVFormatContext *s)
> > >      st->codecpar->codec_id = s->iformat->raw_codec_id;
> > >      st->need_parsing = AVSTREAM_PARSE_FULL_RAW;
> > >
> > > -    st->avg_frame_rate = s1->framerate;
> > >      st->internal->avctx->framerate = s1->framerate;
> > > +    st->internal->avctx->time_base = av_inv_q(s1->framerate);
> > >      avpriv_set_pts_info(st, 64, 1, 1200000);
> > 
> > 
> > This seems odd, I thought that we should not touch internal in lavf. Also,
> > are both parts required (- as well as +), or is the + only enough?
> 
> the - part is what is needed
> i added the 2nd part as that was how it was originally before the
> regression

applied the needed
part

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160607/db836f3d/attachment.sig>


More information about the ffmpeg-devel mailing list