[FFmpeg-devel] [PATCH] lavf/img2dec: add ppm pipe demuxer
u at pkh.me
Thu Jun 9 16:35:02 CEST 2016
On Thu, Jun 09, 2016 at 03:59:30PM +0200, Clément Bœsch wrote:
> On Thu, Jun 09, 2016 at 01:35:19PM +0000, Carl Eugen Hoyos wrote:
> > Clément Bœsch <u <at> pkh.me> writes:
> > > + if (b == '#')
> > > + return AVPROBE_SCORE_EXTENSION + 1;
> > > + if (b >= '0' && b <= '9')
> > > + return AVPROBE_SCORE_MAX - 1;
> > Imo, this should be:
> > if (b == '#' || (b >= '0' && b <= '9'))
> > return AVPROBE_SCORE_EXTENSION + 2;
> > or similar
> > I count 37 and 34 bits which is only a little more than
> > the usual 32 bit for EXTENSION + 1.
> Sure. Changed locally, will push soon, thanks.
For some reasons it makes seeking with pgm somehow working. The reference
test doesn't look that great IIUC, but seeking in these file with ffplay
is fine AFAICT.
Is this change acceptable?
More information about the ffmpeg-devel