[FFmpeg-devel] [PATCH] PPC64: Add IBM POWER8 SIMD Implementation

Dan Parrot dan.parrot at mail.com
Wed Jun 15 16:46:12 CEST 2016


On Wed, 2016-06-15 at 10:15 +0200, Michael Niedermayer wrote:
> On Wed, Jun 15, 2016 at 04:25:11AM +0000, Dan Parrot wrote:
> > This is the first commit addressing Trac ticket #5570. Functions defined in
> > libswscale/input.c have corresponding definitions in libswscale/ppc/input_vsx.h
> > The corresponding function names in the latter contain the suffix "_vsx".
> > ---
> >  libswscale/input.c         |  44 +--
> >  libswscale/ppc/input_vsx.h | 831 +++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 853 insertions(+), 22 deletions(-)
> >  create mode 100644 libswscale/ppc/input_vsx.h
> 
> breaks build on x86
>  ./configure && make -j12
> In file included from libswscale/input.c:44:0:
> libswscale/ppc/input_vsx.h: In function ‘rgb64ToY_c_template_vsx’:
> libswscale/ppc/input_vsx.h:34:5: error: ‘vector’ undeclared (first use in this function)
> libswscale/ppc/input_vsx.h:34:5: note: each undeclared identifier is reported only once for each function it appears in
> libswscale/ppc/input_vsx.h:34:12: error: expected ‘;’ before ‘int’
> libswscale/ppc/input_vsx.h:35:12: error: expected ‘;’ before ‘int’
> libswscale/ppc/input_vsx.h:36:12: error: expected ‘;’ before ‘int’
> 
> [...]
> > @@ -978,7 +984,6 @@ av_cold void ff_sws_init_input_funcs(SwsContext *c)
> >      case AV_PIX_FMT_GBRP9LE:
> >          c->readChrPlanar = planar_rgb9le_to_uv;
> >          break;
> > -    case AV_PIX_FMT_GBRAP10LE:
> >      case AV_PIX_FMT_GBRP10LE:
> >          c->readChrPlanar = planar_rgb10le_to_uv;
> >          break;
> > @@ -996,7 +1001,6 @@ av_cold void ff_sws_init_input_funcs(SwsContext *c)
> >      case AV_PIX_FMT_GBRP9BE:
> >          c->readChrPlanar = planar_rgb9be_to_uv;
> >          break;
> > -    case AV_PIX_FMT_GBRAP10BE:
> >      case AV_PIX_FMT_GBRP10BE:
> >          c->readChrPlanar = planar_rgb10be_to_uv;
> >          break;
> > @@ -1260,8 +1264,6 @@ av_cold void ff_sws_init_input_funcs(SwsContext *c)
> >      case AV_PIX_FMT_GBRP9LE:
> >          c->readLumPlanar = planar_rgb9le_to_y;
> >          break;
> > -    case AV_PIX_FMT_GBRAP10LE:
> > -        c->readAlpPlanar = planar_rgb10le_to_a;
> >      case AV_PIX_FMT_GBRP10LE:
> >          c->readLumPlanar = planar_rgb10le_to_y;
> >          break;
> > @@ -1281,8 +1283,6 @@ av_cold void ff_sws_init_input_funcs(SwsContext *c)
> >      case AV_PIX_FMT_GBRP9BE:
> >          c->readLumPlanar = planar_rgb9be_to_y;
> >          break;
> > -    case AV_PIX_FMT_GBRAP10BE:
> > -        c->readAlpPlanar = planar_rgb10be_to_a;
> >      case AV_PIX_FMT_GBRP10BE:
> >          c->readLumPlanar = planar_rgb10be_to_y;
> >          break;
> 
> why do you remove these ?
> thats not ppc related
> 
> [...]
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Did not intend to touch anything non-PPC. I didn't review git diff
carefully enough. I'll resend patch with modifications only for PPC.




More information about the ffmpeg-devel mailing list