[FFmpeg-devel] [PATCH 1/3] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

Michael Niedermayer michael at niedermayer.cc
Sat Jun 18 02:32:19 CEST 2016


On Thu, Jun 16, 2016 at 11:16:05AM -0700, Jon Toohill wrote:
> Also removes decoder delay compensation from libmp3lame and mp3enc.
> initial_padding specifies only encoder delay, decoder delay is
> handled by start_skip_samples.
> ---
>  libavcodec/libmp3lame.c | 2 +-
>  libavformat/mp3dec.c    | 2 ++
>  libavformat/mp3enc.c    | 9 ++++++---
>  3 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c
> index 5642264..198ac94 100644
> --- a/libavcodec/libmp3lame.c
> +++ b/libavcodec/libmp3lame.c
> @@ -137,7 +137,7 @@ static av_cold int mp3lame_encode_init(AVCodecContext *avctx)
>      }
>  
>      /* get encoder delay */
> -    avctx->initial_padding = lame_get_encoder_delay(s->gfp) + 528 + 1;
> +    avctx->initial_padding = lame_get_encoder_delay(s->gfp);
>      ff_af_queue_init(avctx, &s->afq);
>  
>      avctx->frame_size  = lame_get_framesize(s->gfp);

you are changing a field of the public API
changing public API without major version bumps is tricky, we dont want
to break applications linkng to a newer lib

is there software that uses this?
software that would break if this is applied ? (or maybe it wuld fix
some software usig it)

If this is a bugfix it should be documented in APIChanges with
minor version bumps, any available references to specifications
should be added too

Such bugfix should also be seperate of other unrelated changes


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160618/52cb8798/attachment.sig>


More information about the ffmpeg-devel mailing list