[FFmpeg-devel] [PATCH] Changed metadata print option to accept general urls

Michael Niedermayer michael at niedermayer.cc
Sat Jun 25 13:38:23 CEST 2016

On Thu, Jun 23, 2016 at 12:14:47AM +0000, sami.hult at gmail.com wrote:
> From: Sami Hult <sami.hult at gmail.com>
> I changed output=print file handling of metadata filter to accept any ffmpeg url. This way multiple streams can for example be silencedetected and the result directed to different outputs.
> Example:
> ffmpeg -i test.wav -filter_complex "silencedetect=n=-40dB:d=0.1,ametadata=mode=print:file='pipe\:4'" -f null - 4> test.txt
> should have the same effect as
> ffmpeg -i test.wav -filter_complex "silencedetect=n=-40dB:d=0.1,ametadata=mode=print:test.txt" -f null -
> Signed-off-by: Sami Hult <sami.hult at gmail.com>
> ---
>  Changelog                |  1 +
>  libavfilter/f_metadata.c | 43 +++++++++++++++++++++++--------------------
>  2 files changed, 24 insertions(+), 20 deletions(-)

doesnt build:
libavfilter/f_metadata.c: In function ‘print_file’:
libavfilter/f_metadata.c:187:9: error: format not a string literal and no format arguments [-Werror=format-security]

also change to documentation is missing

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160625/04aac1f3/attachment.sig>

More information about the ffmpeg-devel mailing list