[FFmpeg-devel] [PATCH] configure: use c++98 for c++ files

[Michael Niedermayer]

On Sun, Jun 26, 2016 at 05:44:11PM -0400, Richard Kern wrote:
> 
> > On Jun 26, 2016, at 5:26 PM, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > 
> > On Sun, Jun 26, 2016 at 05:22:01PM -0400, Richard Kern wrote:
> >> 
> >>> On Jun 26, 2016, at 5:10 PM, Michael Niedermayer <michael at niedermayer.cc> wrote:
> >>> 
> >>> On Sun, Jun 26, 2016 at 04:44:40PM -0400, Rick Kern wrote:
> >>>> Use c++98 standard instead of c++11.
> >>>> 
> >>>> Signed-off-by: Rick Kern <kernrj at gmail.com>
> >>>> ---
> >>>> configure | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>> 
> >>>> diff --git a/configure b/configure
> >>>> index 19aea61..76d2d27 100755
> >>>> --- a/configure
> >>>> +++ b/configure
> >>>> @@ -4529,7 +4529,7 @@ fi
> >>>> 
> >>>> add_cppflags -D_ISOC99_SOURCE
> >>>> add_cxxflags -D__STDC_CONSTANT_MACROS
> >>>> -add_cxxflags -std=c++11
> >>>> +add_cxxflags -std=c++98
> >>> 
> >>> should this not be check_cxxflags ?
> >> 
> >> Some c++ standard needs to be there to override the -std=c99 that gets pulled in from CFLAGS.
> > 
> > but does every compiler support -stc=... ?
> > if one doesnt the c99 case would not have been added
> 
> What about filtering the -std=c99 out of CFLAGS in the CXXFLAGS assignment?

have you confirmed that -std=c99 is the problem ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160626/0be53bc5/attachment.sig>