[FFmpeg-devel] ogg audio muxing bug and patch

Alex Balk abalk at brightcove.com
Tue Jun 28 19:39:32 CEST 2016


Attached patch fixes an int<-->uint bug affecting muxing of ogg audio.

This line is the problem:
https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/oggparsevorbis.c#L476

You can see in:
https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/oggdec.h#L68 that
`os->pduration` is an `unsigned int`, but over at
https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/oggparsevorbis.c#L409
the `duration` local is just an `int`...  So when `duration` is negative,
it's getting converted to a large positive 32-bit unsigned int.


ab
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pduration.patch
Type: application/octet-stream
Size: 1416 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160628/648d9ca3/attachment.obj>


More information about the ffmpeg-devel mailing list