[FFmpeg-devel] [PATCH] fate: add filter-hls

James Almer jamrial at gmail.com
Tue Mar 1 04:17:33 CET 2016


On 2/29/2016 11:47 PM, Michael Niedermayer wrote:
> ---
>  tests/fate/filter-audio.mak |    7 +
>  tests/ref/fate/filter-hls2  |  768 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 775 insertions(+)
>  create mode 100644 tests/ref/fate/filter-hls1
>  create mode 100644 tests/ref/fate/filter-hls2
> 
> diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
> index 85a36d2..a330a93 100644
> --- a/tests/fate/filter-audio.mak
> +++ b/tests/fate/filter-audio.mak
> @@ -3,6 +3,13 @@ fate-filter-adelay: tests/data/asynth-44100-2.wav
>  fate-filter-adelay: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav
>  fate-filter-adelay: CMD = framecrc -i $(SRC) -af adelay=42
>  
> +FATE_AFILTER-$(call ALLYES, HLS_DEMUXER MOV_MUXER MOV_DEMUXER AEVALSRC_FILTER LAVFI_INDEV MP2FIXED_ENCODER) += fate-filter-hls1 fate-filter-hls2

Shouldn't it be MPEGTS instead of MOV?

> +tests/data/hls-list.m3u8: fate-filter-hls1
> +fate-filter-hls1: CMD = run ffmpeg -f lavfi -i "aevalsrc=cos(2*PI*t)*sin(2*PI*(440+4*t)*t)::d=20" -f segment -segment_time 10 -map 0 -flags +bitexact -codec:a mp2fixed \
> +                                   -segment_list $(TARGET_PATH)/tests/data/hls-list.m3u8 $(TARGET_PATH)/tests/data/hls-out-%03d.ts

Add a "fate-filter-hls1: REF = /dev/null" line here to avoid the empty ref file.

> +fate-filter-hls2: tests/data/hls-list.m3u8

Why not just add fate-filter-hls1 as dep here, and get rid of the m3u8 target above?

> +fate-filter-hls2: CMD = framecrc -flags +bitexact -i $(TARGET_PATH)/tests/data/hls-list.m3u8
> +
>  FATE_AMIX += fate-filter-amix-simple
>  fate-filter-amix-simple: CMD = ffmpeg -filter_complex amix -i $(SRC) -ss 3 -i $(SRC1) -f f32le -
>  fate-filter-amix-simple: REF = $(SAMPLES)/filter/amix_simple.pcm
> diff --git a/tests/ref/fate/filter-hls1 b/tests/ref/fate/filter-hls1
> new file mode 100644
> index 0000000..e69de29

No comments about the actual test, but it trust you it's ok.


More information about the ffmpeg-devel mailing list