[FFmpeg-devel] [PATCH 4/4] avcodec/dca: make reading past end of buffer safe
foobaz86 at gmail.com
Thu Mar 3 16:17:58 CET 2016
On Thu, Mar 03, 2016 at 12:56:42AM +0100, Hendrik Leppkes wrote:
> On Thu, Mar 3, 2016 at 12:37 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > Completely random comment, but isn't it easier to just enable the safe
> > bitstream reader?
> This is actually enabled by default, so it probably should never have
> overread anywhere, but if the code can be made a bit safer in itself
> it probably does no harm either way.
Interesting. I assumed it was the opposite (safe bitstream reader
disabled by default). In this case the issue this patch addresses
doesn't seem to have as much impact as I initially thought.
But still I think it is a nice change to have since it makes code more
robust overall while not introducing significant performance penalty.
More importantly, it also gets rid of artificial limit on the length of
unary part of Rice codes, which may improve correctness of the decoder.
I'll change the commit message accordingly and resend the patch.
More information about the ffmpeg-devel