[FFmpeg-devel] [PATCH] avcodec: try to document timebase and framerate a bit more

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Mar 5 18:01:11 CET 2016

On Sat, Mar 05, 2016 at 01:41:32PM +0100, Michael Niedermayer wrote:
> +     * Note, for variable framerate material this has undefined meaning currently
> +     * and is not set to the actual framerate nor {0,1} but can be set to
> +     * 1/timebase (FIXME) the code in some parts assumes framerate == 1/timebase
> +     * which is generally not true but these parts need to be fixed before framerate
> +     * can be fixed.

This is too complex, maybe it can be split in multiple sentences.
Suggestion (but I took a lot of liberty and it might not say what you

Note: meaning is not yet defined for variable frame rate content.
Ideally it should be set to either the current frame rate or {0,1}
for that case.
However for this some code assuming framerate == 1/timebase needs to
be fixed first - until then this field may incorrectly be set
to 1/timebase.

More information about the ffmpeg-devel mailing list