[FFmpeg-devel] [PATCH 1/3] lavf/riffenc: Improve spec compliance

Hendrik Leppkes h.leppkes at gmail.com
Fri Mar 11 09:18:43 CET 2016

On Fri, Mar 11, 2016 at 5:10 AM, Mats Peterson
<matsp888-at-yahoo.com at ffmpeg.org> wrote:
> Regarding the biClrUsed field, I'm setting it to 1 <<
> bits_per_coded_sample if palettized video, since setting it to 0 is
> another case where it won't work with Windows Media Player and Microsoft
> Video 1 in 8 bpp mode.

This is not "spec compliance" then, because the spec specifically says
that when its 0, it should be assumed equal to 2^biBitCount, which is
the same value you are explicitly writing now.
Its a redundant value to work around the inability of some players,
not spec compliance - the existing value is perfectly compliant.
Please clarify as much in any potential commit message.

- Hendrik

More information about the ffmpeg-devel mailing list