[FFmpeg-devel] [PATCH] lavc/aacenc_quantization: use cbrt table

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Mar 12 19:24:37 CET 2016

On Sat, Mar 12, 2016 at 12:09:13PM -0500, Ganesh Ajjanagadde wrote:
> And yes, for me the proof of the pudding is in the eating. In other
> words, if you or someone else sends a small, simple patch achieving
> the above one-line change, I will be very happy and will learn
> something.

I don't think that one line change is the problem.
The problem is moving the tables into a .c file.
And the biggest issue there is actually the fixed/non-fixed split.
Which you kind of avoided by always including both tables, even
if e.g. the fixed point would never be used.
That part was most painful for me :)
And I am still unclear where I should use AAC_RENAME and where
(especially for the headers) I can just assume one or the other.
I'll send a patch that does the data sharing, leaving the
one-liner to you :)

More information about the ffmpeg-devel mailing list