[FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

[Michael Niedermayer]

On Wed, Mar 16, 2016 at 10:24:09PM +0100, Thilo Borgmann wrote:
> Am 16.03.16 um 21:10 schrieb Moritz Barsnick:
> > [...]
> 
> All addressed in newest patch, thanks!
> 
> > - You have a variable by the same name as a function (list_filters),
> >   but Objective C may not mind. (Does ffmpeg coding style mind?)
> 
> I've done it in the OSX/iOS devices as well and nobody complained...
> The compilers don't complain either because it is either struct.varname
> or (*varname)().
> 
> Updated patch attached.
> 
> -Thilo

>  Changelog                  |    1 
>  MAINTAINERS                |    1 
>  configure                  |    2 
>  doc/filters.texi           |  165 ++++++++++
>  libavfilter/Makefile       |    1 
>  libavfilter/allfilters.c   |    2 
>  libavfilter/vf_coreimage.m |  716 +++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 888 insertions(+)
> a09186f591e02bb162a605a8fc0add3490323dd5  0002-lavf-Add-coreimage-filter-for-GPU-based-image-filter.patch
> From b6b889c06edc7872f0a31fd0482793a199ddd28e Mon Sep 17 00:00:00 2001
> From: Thilo Borgmann <thilo.borgmann at mail.de>
> Date: Wed, 16 Mar 2016 22:18:20 +0100
> Subject: [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering
>  on OSX.

breaks build on linux
LD      ffmpeg_g
libavfilter/libavfilter.a(allfilters.o): In function `avfilter_register_all':
ffmpeg/libavfilter/allfilters.c:306: undefined reference to `ff_vsrc_coreimagesrc'
collect2: ld returned 1 exit status
make: *** [ffmpeg_g] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160318/482fd3db/attachment.sig>