[FFmpeg-devel] [PATCH 1/3] configure: Force mingw's ld to keep the reloc section
christophe.gisquet at gmail.com
Sun Mar 20 11:29:12 CET 2016
2016-03-19 19:08 GMT+01:00 Ismail Donmez <ismail at i10z.com>:
>> 2016-03-11 8:57 GMT+01:00 Christophe Gisquet <christophe.gisquet at gmail.com>:
>>>> It should either be reverted or made dependent on
>>>> --enable/disable-debug (I would favor the first, honestly, since its a
>>>> rather ugly hack in itself).
>> I don't have a strong opinion on actually reverting it, but would lean for it.
> Please don't disable it for release builds, it improves the security
> of the resulting executable.
I understand the sentiment, and there's probably little lost in
keeping it, but... is it not a hack? ie:
- When do you notice the added security is no longer there/it breaks
in even worse ways?
- Who is and would be available and able to prevent it from breaking?
Because it already has, and almost nobody dealt with it.
The original author already did well in reporting the issue to
binutils, so I'm certainly not complaining about his efforts.
More information about the ffmpeg-devel