[FFmpeg-devel] [PATCH 4/4] avformat/mov: add support for reading end padding from gapless itunes metadata

Michael Niedermayer michael at niedermayer.cc
Tue Mar 22 09:54:51 CET 2016


On Mon, Mar 21, 2016 at 01:06:21AM +0100, Marton Balint wrote:
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavformat/mov.c                            | 13 ++++++++++---
>  tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 12 ++++++------
>  tests/ref/fate/gaplessinfo-itunes1           |  2 +-
>  tests/ref/fate/gaplessinfo-itunes2           |  2 +-
>  4 files changed, 18 insertions(+), 11 deletions(-)

breaks (latest) fate

some tests seem improve some seem to get worse

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160322/4a901e89/attachment.sig>


More information about the ffmpeg-devel mailing list