[FFmpeg-devel] [PATCH 1/2] lavu/dict: Add new flag to allow multiple equal keys.
thilo.borgmann at mail.de
Mon Mar 28 00:10:20 CEST 2016
Am 26.03.16 um 01:49 schrieb Hendrik Leppkes:
> On Sat, Mar 26, 2016 at 1:12 AM, Thilo Borgmann <thilo.borgmann at mail.de> wrote:
>>> When you go from talking about a developers concerns to just pushing,
>>> then how else do you think someone should feel?
>> You are again ignoring what I did and what I've written in the previous
>> mails to explain what I did and why I did it.
>> Basically you're just repeating that in your opinion I "just pushed". As
>> long as you don't explain why you think that way with respect to what
>> I've written there will be no progress in this discussion.
>> That's a pity because we both are obviously thinking that this is an
>> important topic. Unfortunately, I think I did what you demand - I pinged
>> after there was a significant silence after the last review.
>> It is on you to prove me wrong for convincing me that I made a mistake
>> by pushing too early.
> None of the posts in this thread are a ping, all I see is back and
> forth between two developers.
> A ping would generally explictily ask for further feedback after a
> time of silence, or anything like that, I don't see that here. For all
> I knew, you were waiting for a response from wm4 on the last mail, it
> was only a few days ago afterall.
Yes there was a ping and obviously at least wm4 himself thinks so, too.
Go ahead and tell me that wm4 replying to it a minute a minute later
has happened by chance and not because of my ping.
> This way, it would be clear to everyone reading, and someone else
> might comment, instead I was thinking wm4 gave criticism, and this
> would be hashed out before its pushed, especially since the general
> rule is that when a developer has an issue with a patch, it shouldn't
> be pushed until he was convinced otherwise or the patch adjusted, if
What is exactly what has happened. From my viewpoint at least. Obviously
wm4 and you don't think that not replying anymore leads to silent
approval - I do. This seems to be what we are talking about.
After wm4's first response, I answered with stating my motivation and
concerns about the alternatives that came to mind.
Then he was silent. This I would already call to be sorted out.
After my ping he basically repeated his statement and remained silent
again although I explicitly asked him for his suggestions this time.
This is what you call in the middle of discussion?
If we were actually sorting something out I would never have pushed
anything but that was just not the case. If that would have been the
case, don't you think there would already be a tremendous shitstorm
going down on me?
> This also doesn't answer the question that this patch was never
> excplicitly OK'ed.
>From my point of view it was implicitly OK'ed after the last review of
patch 2 and ongoing silence after my ping.
More information about the ffmpeg-devel