[FFmpeg-devel] [PATCH 1/2] lavu/dict: Add new flag to allow multiple equal keys.
nfxjfg at googlemail.com
Mon Mar 28 15:56:18 CEST 2016
On Mon, 28 Mar 2016 12:05:10 +0200 (CEST)
Marton Balint <cus at passwd.hu> wrote:
> On Mon, 28 Mar 2016, Hendrik Leppkes wrote:
> > People that don't speak up at all may approve silently (or at least
> > not disapprove), someone that raised issues should give an explicit
> > OK/Nevermind/whatever, agreeing with you or withdrawing his
> > complaints, there is no "silent" option there.
> This seems unreasonable, beacuse this way a silent person can block a
> patch forever, which is not optimal.
> What I usually do is after a week of silence if I feel that I addressed
> the concerns, or there is no known way to improve the patch, I send
> one last ping explicitly stating that I will apply the patch soon.
> (whithin 1-2 days). And if the silence remains, I apply it.
In any case I agree that my behavior wasn't ideal. I was thinking more
along the lines that I didn't really care, but someone really should
have cared. I didn't want this issue to be overlooked at least.
More information about the ffmpeg-devel