[FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Matt Oliver protogonoi at gmail.com
Tue Mar 29 08:16:29 CEST 2016

> +enabled coreimage_filter  && { check_header_objcc QuartzCore/CoreImage.h
> || disable coreimage_filter; }
> +enabled coreimagesrc_filter && { check_header_objcc
> QuartzCore/CoreImage.h || disable coreimagesrc_filter; }

Wouldnt it be simpler to just add an item to HEADERS_LIST for
QuartzCore_CoreImage_h then this check only needs to be done once as both
filters can then just depend on the header list entry.
check_header_objcc QuartzCore/CoreImage.h

This would also remove the need for the duplicate  _extralibs= lines aswell.

VideoToolbox currently does something like this although much more
complicated as it was added as an external lib despite being in a similar
boat to coreimage.

FYI I noticed what looks like an error in check_header_objcc as the code
"enable_safe $headers" I believe should be "enable_safe $header" (no 's').
I dont have OSX to double check this.

More information about the ffmpeg-devel mailing list