[FFmpeg-devel] [PATCH] lavfi: new colorspace conversion filter.

Michael Niedermayer michael at niedermayer.cc
Thu Mar 31 02:16:59 CEST 2016

On Wed, Mar 30, 2016 at 04:35:18PM -0400, Ronald S. Bultje wrote:
> The intent here is similar to colormatrix, but it's LGPLv2.1-or-later
> (instead of GPLv2.0) and supports gamma/chromaticity correction.
> ---
>  libavfilter/Makefile                 |   1 +
>  libavfilter/allfilters.c             |   1 +
>  libavfilter/colorspacedsp.c          | 130 ++++++
>  libavfilter/colorspacedsp.h          |  51 +++
>  libavfilter/colorspacedsp_template.c | 256 ++++++++++++
>  libavfilter/vf_colorspace.c          | 773 +++++++++++++++++++++++++++++++++++
>  6 files changed, 1212 insertions(+)
>  create mode 100644 libavfilter/colorspacedsp.c
>  create mode 100644 libavfilter/colorspacedsp.h
>  create mode 100644 libavfilter/colorspacedsp_template.c
>  create mode 100644 libavfilter/vf_colorspace.c

It would be better if all colorspace and pixel convert code would be
in the same lib.
Especially for automatic convertion

swscale since last GSoC applies the individual scale and convert steps
through a more generic system, and should be possible to add this
in there. Quite possibly that would be more work and require some more
changes and cleanup in swscale.
swscale also supports spliting convertions into multiple swscalers,
so you could easily have a swscale that uses this as a special
converter connected to a 2nd swscale that does all the rest.

Also iam sure pedro would help and awnser any questions as his time
permits about the improvments added in last GSoC.

anyway thats not a objection, i just think this isnt the best way
to implement this

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160331/742b570c/attachment.sig>

More information about the ffmpeg-devel mailing list