[FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.
Ronald S. Bultje
rsbultje at gmail.com
Tue May 10 16:50:24 CEST 2016
On Tue, May 3, 2016 at 10:21 PM, Michael Niedermayer <michael at niedermayer.cc
> On Tue, May 03, 2016 at 08:58:07PM -0400, Ronald S. Bultje wrote:
> > Hi,
> > On Tue, May 3, 2016 at 8:29 PM, Michael Niedermayer
> <michael at niedermayer.cc>
> > wrote:
> > > On Tue, May 03, 2016 at 03:21:00PM -0400, Ronald S. Bultje wrote:
> > > > I have no idea why the first hunk uses ost->enc_ctx, because as far
> > > > I understand, that is never used in case of -c:v copy, but this code
> > > > block is only entered if encoding_needed=0, which means
> > >
> > > when the code was added it was followed by a
> > > ret = avcodec_copy_context(ost->st->codec, ost->enc_ctx);
> > > later that was removed
> > >
> > >
> > > do you have a testcase for which this hunk makes a differnce?
> > ffmpeg -i any_webm_file -color_trc 4 -strict -2 -c:v copy out.webm
> > Will set the colorspace element in the muxer after, but not before, this
> > patch.
> patch should be ok
> can you add a testcase for this to fate ?
> so this doesnt break, nothing in fate tests this
> even commenting the code out entirely made fate still pass
(Testcase pushed also, as mentioned in the relevant thread for that patch.)
More information about the ffmpeg-devel