[FFmpeg-devel] [PATCH v2] avformat/flvenc: add add_keyframe_index option

[Michael Niedermayer]

On Sat, Nov 05, 2016 at 08:44:01PM +0800, Steven Liu wrote:
> Add keyframe index metadata
> Used to facilitate seeking; particularly for HTTP pseudo streaming.
>  1. read live streaming or file by sequence
>  2. if use add_keyframe_index option, add a mark flag at the position, use to insert new context at the last step.
>  3. add the keyframes *offset* and *timestamp* into a list
>  4. if use add_keyframe_index option, shift the metadata data from mark flag offset
>  5. insert the keyframes *offset* and *timestamp* from the list by sequence
>  6. free the list
>  7. end.
> 
> Reviewed-by: Lou Logan <lou at lrcd.com>
> Signed-off-by: Steven Liu <liuqi at gosun.com>
> ---
>  doc/muxers.texi      |    3 +
>  libavformat/flvenc.c |  331 ++++++++++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 324 insertions(+), 10 deletions(-)

LGTM

please also add a fate test

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161105/80537015/attachment.sig>