[FFmpeg-devel] [PATCH] vp9: add avx2 iadst16 implementations.

[Ronald S. Bultje]

Hi,

On Tue, Nov 8, 2016 at 2:43 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:

> Hi,
>
> On Tue, Nov 8, 2016 at 2:39 PM, Michael Niedermayer <
> michael at niedermayer.cc> wrote:
>
>> On Tue, Nov 08, 2016 at 11:22:31AM -0500, Ronald S. Bultje wrote:
>> > Also a small cosmetic change to the avx2 idct16 version to make it
>> > explicit that one of the arguments to the write-out macros is unused
>> > for >=avx2 (it uses pmovzxbw instead of punpcklbw).
>> > ---
>> >  libavcodec/x86/vp9dsp_init.c |   8 +-
>> >  libavcodec/x86/vp9itxfm.asm  | 188 ++++++++++++++++++++++++++++++
>> ++++++++++---
>> >  2 files changed, 183 insertions(+), 13 deletions(-)
>>
>> x86-32 linux gets stomach ache from this:
>>
>> YASM    libavcodec/x86/vp9itxfm.o
>> src/libavcodec/x86/vp9itxfm.asm:2150: error: instruction expected after
>> label
>> src/libavcodec/x86/vp9itxfm.asm:2151: error: instruction expected after
>> label
>> src/libavcodec/x86/vp9itxfm.asm:2152: error: instruction expected after
>> label
>
>
> Ah right, yes this is meant to be for 64bit only. I'll add some #if/%if
> around it...
>

They were already there but one %endif was misplaced. Fixed locally.

Ronald