[FFmpeg-devel] [PATCH] proresdec_lgpl: explicitly check coff[3] against slice_data_size

Michael Niedermayer michael at niedermayer.cc
Thu Nov 10 15:38:09 EET 2016


On Wed, Nov 09, 2016 at 11:56:36PM +0100, Andreas Cadhalpun wrote:
> The implicit checks via v_data_size and a_data_size don't work in the case
> '(hdr_size > 7) && !ctx->alpha_info'.
> 
> This fixes segmentation faults due to invalid reads.
> 
> This problem was introduced in commit
> 547c2f002a87f4412a83c23b0d60364be5e7ce58.
> 
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  libavcodec/proresdec_lgpl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161110/4c18b379/attachment.sig>


More information about the ffmpeg-devel mailing list