[FFmpeg-devel] [Patch] hwaccel transocode broken

[wm4]

On Fri, 11 Nov 2016 10:19:08 +0100
Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> 2016-11-11 9:03 GMT+01:00 Hendrik Leppkes <h.leppkes at gmail.com>:
> > On Fri, Nov 11, 2016 at 6:34 AM, Yogender Gupta <ygupta at nvidia.com> wrote:  
> >>>>I was trying libnpp on Big Bunny video by below command:  
> >>
> >>
> >>  
> >>>>./ffmpeg -loglevel debug -y -hwaccel cuvid -c:v h264_cuvid -vsync 0 -i  
> >>  
> >>>>/root/root/bunny.mp4 -vf scale_npp=1920:1072 -vcodec h264_nvenc  
> >>  
> >>>>/tmp/tmp0.264 -vf scale_npp=1280:720 -vcodec h264_nvenc /tmp/tmp1.264  
> >>
> >>
> >>  
> >>>>This command is working with below Git version:  
> >>  
> >>>>https://git.ffmpeg.org/gitweb/ffmpeg.git/snapshot/077939626eeaa0c1364065414c18ab9b3a072281.tar.gz  
> >>
> >> The hwaccel transcode functionality seem to have broken with the following commit
> >>
> >> 7 days ago
> >>
> >> Hendrik Leppkes<http://git.videolan.org/?p=ffmpeg.git;a=search;s=Hendrik+Leppkes;st=author>
> >>
> >> Merge commit '722ec3eb35bc152ce91d0a4502eca0df1c0086d0'<http://git.videolan.org/?p=ffmpeg.git;a=commit;h=b6422902d84ec8df6f5a64ffd8743e93307bd8e9>
> >>
> >> commit<http://git.videolan.org/?p=ffmpeg.git;a=commit;h=b6422902d84ec8df6f5a64ffd8743e93307bd8e9> | commitdiff<http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=b6422902d84ec8df6f5a64ffd8743e93307bd8e9> | tree<http://git.videolan.org/?p=ffmpeg.git;a=tree;h=b6422902d84ec8df6f5a64ffd8743e93307bd8e9;hb=b6422902d84ec8df6f5a64ffd8743e93307bd8e9>
> >>
> >>
> >> The included patch should fix.
> >>  
> >
> > ffmpeg.c is in the middle of some changes being merged, and once that
> > is done ffmpeg_cuvid.c will need to be adapted to a new system. Until
> > then, it would make everything easier if the code actively being
> > modified by these merges is not modified by hackish fixes.  
> 
> Iirc, the documentation requires to only commit patches that do not
> (knowingly) break functionality and imo, this implies that you should
> quickly fix such bugs once they are reported. Or do I miss something?

These are merges. Unless you volunteer to do the merges yourself (and
properly please) you'll have to live with this.