[FFmpeg-devel] [PATCH] oggparsevp8: set need_context_update when changing codec id

[James Almer]

On 11/15/2016 6:51 PM, Andreas Cadhalpun wrote:
> Otherwise the codec context and codecpar might disagree on the codec id,
> triggering asserts in av_parser_parse2.
> 
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  libavformat/oggparsevp8.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/oggparsevp8.c b/libavformat/oggparsevp8.c
> index c534ab1..86495ae 100644
> --- a/libavformat/oggparsevp8.c
> +++ b/libavformat/oggparsevp8.c
> @@ -62,6 +62,7 @@ static int vp8_header(AVFormatContext *s, int idx)
>          st->codecpar->codec_type = AVMEDIA_TYPE_VIDEO;
>          st->codecpar->codec_id   = AV_CODEC_ID_VP8;
>          st->need_parsing      = AVSTREAM_PARSE_HEADERS;
> +        st->internal->need_context_update = 1;

I'm not sure i understand what's the use for this or how codec_id can be
anything else, but in any case why is this implemented in a different way
than in your oggparsetheora patch?