[FFmpeg-devel] [PATCH] compat/atomics: merge the C11 atomics from Libav

Michael Niedermayer michael at niedermayer.cc
Thu Nov 24 02:08:46 EET 2016


On Wed, Nov 23, 2016 at 03:44:12PM -0800, Wan-Teh Chang wrote:
> From: Anton Khirnov <anton at khirnov.net>
> 
> Merge the following libav commits:
> 13f5d2bf75b95a0bfdb9940a5e359a719e242bed
> 4e928ef340ac20325f529d92fcbc51e768085358
> c2755864afadfbaa349e8d583665c86fe99fa90b
> bb81ed476569b912a37ed553e756e123b6b13b14
> f9a6a80e065cdb95b233978f1d96ec9bc863daa1
> eb34d40354e2474517c9b9bd787e0dadc89c2a81

please read
http://ffmpeg.org/developer.html

for example it says:
"Do not commit unrelated changes together."

you combined commits which were split before


"Testing must be adequate but not excessive.
 If it works for you, others, and passes FATE then it should be OK to commit it, provided it fits the other committing criteria. You should not worry about over-testing things. If your code has problems (portability, triggers compiler bugs, unusual environment etc) they will be reported and eventually fixed. "

this fails fate

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161124/e73d7cbd/attachment.sig>


More information about the ffmpeg-devel mailing list