[FFmpeg-devel] [PATCH] compat/atomics: merge the C11 atomics from Libav

Wan-Teh Chang wtc at google.com
Thu Nov 24 02:54:51 EET 2016


On Wed, Nov 23, 2016 at 4:08 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> please read
> http://ffmpeg.org/developer.html
>
> for example it says:
> "Do not commit unrelated changes together."
>
> you combined commits which were split before

Those changes are closely related. But I will merge those six commits
one at a time.

> "Testing must be adequate but not excessive.
>  If it works for you, others, and passes FATE then it should be OK to commit it, provided it fits the other committing criteria. You should not worry about over-testing things. If your code has problems (portability, triggers compiler bugs, unusual environment etc) they will be reported and eventually fixed. "
>
> this fails fate

Sorry about that! I did run "make fate", but I must have forgotten to
check the test results.

I assume I should use the standard FFmpeg license header in the new .h files?

Thanks,
Wan-Teh Chang


More information about the ffmpeg-devel mailing list