[FFmpeg-devel] [PATCH 1/4] Add a compat stdatomic.h implementation based on windows atomics

Wan-Teh Chang wtc at google.com
Tue Nov 29 19:53:56 EET 2016


I studied the history of vlc/include/vlc_atomic.h and compared it wth
libav/compat/atomics/win32/stdatomic.h.

1. vlc/include/vlc_atomic.h was initially written by Rémi
Denis-Courmont. This is the most substantial commit by Rémi
Denis-Courmont:

http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ad3586579f956b6856d2f7c0c4cbd860fd8241af

2. The Windows port was written by Felix Abecassis. Note that he
didn't add his copyright notice to vlc/include/vlc_atomic.h. This is
the most substantial commit by Felix Abecassis:

http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9c077c0d28df2ad7387b4db8702bd023b2556c86

3. libav/compat/atomics/win32/stdatomic.h contains code that is
apparently derived from the code in vlc/include/vlc_atomic.h written
by both Rémi Denis-Courmont and Felix Abecassis, but doesn't have a
copyright notice.

Similarly, libav/compat/atomics/suncc/stdatomic.h contains code that
is apparently derived from the code in vlc/include/vlc_atomic.h
written by Rémi Denis-Courmont, but doesn't have a copyright notice.

4. Given this information, should I add a copyright notice to
ffmpeg/compat/atomics/win32/stdatomic.h and
ffmpeg/compat/atomics/suncc/stdatomic.h?

5. A related question: libav/compat/atomics/pthread/stdatomic.c does
NOT contain any code that is apparently derived from the code in
vlc/include/vlc_atomic.h written by Rémi Denis-Courmont, but
libav/compat/atomics/pthread/stdatomic.c contains a copyright notice
of Rémi Denis-Courmont. Should I remove that copyright notice from
ffmpeg/compat/atomics/pthread/stdatomic.c?

Thanks,
Wan-Teh Chang


More information about the ffmpeg-devel mailing list