[FFmpeg-devel] [PATCH] fate: add test for firequalizer filter

Muhammad Faiz mfcc64 at gmail.com
Thu Oct 13 21:56:46 EEST 2016


On Thu, Oct 13, 2016 at 9:18 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Thu, Oct 13, 2016 at 08:53:30AM +0700, Muhammad Faiz wrote:
>> On Thu, Oct 13, 2016 at 8:19 AM, Michael Niedermayer
>> <michael at niedermayer.cc> wrote:
>> > On Thu, Oct 13, 2016 at 05:14:38AM +0700, Muhammad Faiz wrote:
>> >> Signed-off-by: Muhammad Faiz <mfcc64 at gmail.com>
>> >> ---
>> >>  tests/fate/filter-audio.mak     | 10 ++++++++++
>> >>  tests/filtergraphs/firequalizer | 27 +++++++++++++++++++++++++++
>> >>  2 files changed, 37 insertions(+)
>> >>  create mode 100644 tests/filtergraphs/firequalizer
>> >
>> > works on mingw liunx x86 32/64
>> > but fails on qemu arm
>> > TEST    filter-firequalizer
>> > stddev:    0.68 PSNR: 99.68 MAXDIFF:    1 bytes:  1058400/  1097208
>> > stddev: |0.68 - 0| >= 0.01
>> > Test filter-firequalizer failed. Look at tests/data/fate/filter-firequalizer.err for details.
>> > make: *** [fate-filter-firequalizer] Error 1
>> >
>>
>> new patch with oneoff test
>> patch attached
>>
>> thx
>
>>  fate/filter-audio.mak     |    9 +++++++++
>>  filtergraphs/firequalizer |   27 +++++++++++++++++++++++++++
>>  2 files changed, 36 insertions(+)
>> c7cf3aec0f190b2c5e3eed28d9f5ce22cbbebcfa  0001-fate-add-test-for-firequalizer-filter.patch
>> From e25da07363c2126ac4642794f905678e95bf14a4 Mon Sep 17 00:00:00 2001
>> From: Muhammad Faiz <mfcc64 at gmail.com>
>> Date: Thu, 13 Oct 2016 08:43:50 +0700
>> Subject: [PATCH] fate: add test for firequalizer filter
>
> works fine here
>
> LGTM
>
> please check fate.ffmpeg.org though a day or 2 after its pushed
> some clients might still have larger rounding differences
>
> thx

pushed

thanks


More information about the ffmpeg-devel mailing list