[FFmpeg-devel] [PATCH] avfilter/af_silenceremove: add optional tone when silence is removed

Michael Niedermayer michael at niedermayer.cc
Sat Oct 15 01:14:36 EEST 2016


On Fri, Oct 14, 2016 at 06:09:51PM +0000, Greg Rowe wrote:
> Michael,
> 
> In the attached patch I've tried to make all of the changes you've pointed out.  I also renamed tone_hz to tone_frequency on Moritz Barsnick's suggestion.
> 
> Is there a good way to generate the tone while avoiding floating point operations?  If there is then don't bother reviewing this patch and I'll make that change once I know better how to do it.

see
libavfilter/asrc_sine.c
this code should probably be reused / factored
(note, any code moving/factoring of existing code should be in a
 seperate patch)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161015/a5cb9528/attachment.sig>


More information about the ffmpeg-devel mailing list